Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public link. Change role doesn't work #6429

Closed
ScharfViktor opened this issue Feb 11, 2022 · 3 comments
Closed

Public link. Change role doesn't work #6429

ScharfViktor opened this issue Feb 11, 2022 · 3 comments
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

web: 4.9.0
ocis: 1.16.0 with docker

Steps:

  • admin creates folder
  • admin creates public link with role uploader
  • open public link
  • admin changes role to editor. Request PUT https://host.docker.internal:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/DIXZPcaxJYtctTz - 200 OK
  • refresh old.

Result: rights have not changed

  • copy new new link and open again

Result: rights have not changed

@ScharfViktor ScharfViktor added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Feb 11, 2022
@ScharfViktor ScharfViktor mentioned this issue Feb 11, 2022
25 tasks
@pascalwengerter
Copy link
Contributor

Investigated, interestingly the permissions change seems to be fine (PUT request goes through as expected, share creator can see the changes upon page reload on his UI). The public link however resolves from (e.g.) https://localhost:9200/#/s/eufNbYhpPVzcEWJ to https://localhost:9200/#/files/public/drop/eufNbYhpPVzcEWJ (with a hardcoded drop in the URL) and is stuck in the uploader view

@kulmann kulmann self-assigned this Feb 14, 2022
@kulmann
Copy link
Member

kulmann commented Feb 14, 2022

I fixed the redirect in 67eac46 but it seems like the caching in oCIS is too aggressive. I don't get updated share permissions when fetching a single public link upon loading the public link view. With oc10 as a backend it works just fine now (was broken before the referenced commit).

@ScharfViktor
Copy link
Contributor Author

re-tested in owncloud/ocis#3377
Change role works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants