Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview: filename hovers the image when the viewport is too small #6300

Closed
dschmidt opened this issue Jan 22, 2022 · 3 comments · Fixed by #7216
Closed

preview: filename hovers the image when the viewport is too small #6300

dschmidt opened this issue Jan 22, 2022 · 3 comments · Fixed by #7216
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@dschmidt
Copy link
Member

dschmidt commented Jan 22, 2022

... and becomes unreadable

Screenshot_20220122_135613

... also visible in this screenshot:
neither image nor controls are centered correctly :trollface:

@dschmidt dschmidt added feature:media-viewer Type:Bug Something isn't working labels Jan 27, 2022
@kulmann kulmann added the Priority:p3-medium Normal priority label May 10, 2022
@kulmann kulmann changed the title mediaviewer: filename hovers the image when the viewport is too small preview: filename hovers the image when the viewport is too small May 10, 2022
@AlexAndBear
Copy link
Contributor

@kulmann As we have the toolbar on top for the pdf-viewer and text editor app, we might think about moving the preview toolbar to the top as well, easier to implement + consistency reasons

@pascalwengerter
Copy link
Contributor

@kulmann As we have the toolbar on top for the pdf-viewer and text editor app, we might think about moving the preview toolbar to the top as well, easier to implement + consistency reasons

Bonus points to have them stuck to bottom on mobile screens maybe? 😉 @tbsbdr

@kulmann
Copy link
Member

kulmann commented Jul 5, 2022

@kulmann As we have the toolbar on top for the pdf-viewer and text editor app, we might think about moving the preview toolbar to the top as well, easier to implement + consistency reasons

Yes, all in for the consistency :-) I think we'll have more button-candidates for the topbar, which I would try to align to the top right, see #7160 so having the topbar as you described would be a good preparation for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants