Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return to the main menu after closing the Mediaviewer does not work correctly on public links #6127

Closed
Tracked by #2845
ScharfViktor opened this issue Dec 10, 2021 · 2 comments
Closed
Tracked by #2845

Return to the main menu after closing the Mediaviewer does not work correctly on public links #6127

ScharfViktor opened this issue Dec 10, 2021 · 2 comments
Assignees
@dschmidt
Labels
feature:files Priority:p2-high Escalation, on top of current planning, release blocker

Comments

@ScharfViktor
Copy link
Contributor

Steps to reproduce

  1. add file jpeg and create public link
  2. open public link
  3. open file jpeg in mediaviewer
  4. close mediaviewer and return to main page

Expected behaviour

you go back to the "public link" directory and see the "jpg" file.

BUT: If you create a public link to a folder with a file, it works correctly

Actual behaviour

Screen.Recording.2021-12-10.at.14.33.41.mov

Env:
up ocis local
OCIS_VERSION=v1.16.0
Web_version= v4.6.1
BRANCH=v1.16.0-rc2
@ScharfViktor ScharfViktor added the Priority:p3-medium Normal priority label Dec 10, 2021
@ScharfViktor ScharfViktor mentioned this issue Dec 10, 2021
Closed
29 tasks
@pascalwengerter pascalwengerter changed the title Return to the main menu after closing the Mediaviever does not work correctly Return to the main menu after closing the Mediaviewer does not work correctly Dec 10, 2021
@pascalwengerter pascalwengerter changed the title Return to the main menu after closing the Mediaviewer does not work correctly Return to the main menu after closing the Mediaviewer does not work correctly on public links Dec 10, 2021
@dschmidt dschmidt self-assigned this Dec 11, 2021
@kulmann kulmann added Priority:p2-high Escalation, on top of current planning, release blocker and removed Priority:p3-medium Normal priority labels Dec 13, 2021
@pascalwengerter
Copy link
Contributor

Can't reproduce on current master, seems like #6331 closed it? Can someone confirm it's resolved?

@kulmann
Copy link
Member

kulmann commented Feb 9, 2022

Can't reproduce on current master, seems like #6331 closed it? Can someone confirm it's resolved?

Yep, was fixed in that PR. Closing here

@kulmann kulmann closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dschmidt dschmidt

Labels
feature:files Priority:p2-high Escalation, on top of current planning, release blocker
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dschmidt @kulmann @pascalwengerter @ScharfViktor