Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always redirect requests from the UI to homeFolder #4823

Closed
ishank011 opened this issue Mar 17, 2021 · 8 comments
Closed

Always redirect requests from the UI to homeFolder #4823

ishank011 opened this issue Mar 17, 2021 · 8 comments

Comments

@ishank011
Copy link

With the homeFolder option, the user homes can be configured to arbitrary paths instead of the default root. But the change is not applicable across the UI.

  • Clicking on the home icon in the 'All files' tab should redirect to homeFolder instead of root.
  • Endpoints for the files from the 'Shared with me' and ''Shared with others' should also have the homeFolder prefix.
@kulmann
Copy link
Member

kulmann commented Mar 17, 2021

The home icon in the breadcrumbs is misleading. In fact it represents the root, not the home. Otherwise there would be no other way to navigate up to the root. If there is no homeFolder configured, home is basically the same as root (home = root for the authenticated user). We'll need a better icon anyway when we implement spaces/project folders in the web ui and probably continue to use the breadcrumbs. What do you think?

As for your second point, that's of course correct and needs to be fixed. Do you want to try a PR? :-)

@ishank011
Copy link
Author

@kulmann it makes sense for the breadcrumbs part, I think we can just let it be for now. For the second one, I'll ask people getting started with the project to take a look.

@ishank011
Copy link
Author

@kulmann please take this up when you have the chance. We have quite a few things going on so it'll be difficult to spare time to look into this

@kulmann
Copy link
Member

kulmann commented Mar 25, 2021

alright 👍

@kulmann kulmann mentioned this issue Apr 7, 2021
10 tasks
@kulmann
Copy link
Member

kulmann commented Apr 7, 2021

@ishank011 could you confirm that this is what you need? #4926

To be honest I don't get how in your setup the user has access to the storage root but shares still live in the users homeFolder path. Struggling to write meaningful tests for it. A bit more context about the setup would be helpful.

@kulmann
Copy link
Member

kulmann commented Apr 7, 2021

Pinging @LukasHirt @pascalwengerter @fschade here so that they get updated with more information as well.

@pascalwengerter
Copy link
Contributor

@ishank011 could you update us on whether this has been resolved by cs3org/reva#1605?

@ishank011
Copy link
Author

We can close this since it's being tracked in reva itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants