Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – General Overview when logged in – Adding more headlines #4764

Closed
marcus-herrmann opened this issue Feb 24, 2021 · 1 comment
Closed

Comments

@marcus-herrmann
Copy link
Contributor

Connected to Audit 1, see #4300
1.2 General Overview when logged in, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

In 1.3.1a, BITV's requires that contents are structured by headlines, if a page is "information-oriented". While I personally consider the phoenix interface functionality-oriented, a tester could disagree.

Remediation

Regardless: Adding visually-hidden headlines above certain sections won't hurt nobody. My ideas:

  • <h2 class="visually-hidden">Navigation</h2> above .oc-sidebar-nav ul, and an IDREF to said headline in the <nav>: <nav class="oc-sidebar-nav" aria-labelledby="navHeadline"><h2 lass="visually-hidden" id="navHeadline">Navigation</h2> ...
  • Same for the container wrapping all account functionality: <h2 class="visually-hidden">Account management</h2>
  • Same for the files table: <h2 class="visually-hidden">Files in this folder</h2>

This means the final headline structure could be:
h1 "New Folder" (actual name of the folder one is in)
h2 "Files in this folder"
h2 "Navigation"
h2 "Account Management"

@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants