Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – General Overview when logged in – Page title stays the same all across the app #4338

Closed
marcus-herrmann opened this issue Nov 18, 2020 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

marcus-herrmann commented Nov 18, 2020

Connected to Audit 1, see #4300
1.2 General Overview when logged in, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

Document title stays "ownCloud" no matter what you do and where you are. But should describe the page, route or state that a user is on or on.

Update 2021-02-24: Good advise is to have a constant part of the string, e.g. "owncloud", and a part which is depending on the document you are on (or route you are in): "Foo Bar" (given that is a folder name in your ownCloud). The recommended order is: {individual} - {constant}

Remediation

Set document.title after successful route change to a more descriptive text regarding the "page"/route. Dream Vue code:

  watch: {
    $route: function(to) {
      this.$nextTick(function() {

        document.title = "ownCloud - Einstellungen"; // = "ownCloud settings", for settings route

      });
    }
  },
@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants