From f08c7b5b568db515fe707f68ec19a566665b985e Mon Sep 17 00:00:00 2001 From: saw-jan Date: Mon, 7 Jun 2021 11:02:39 +0545 Subject: [PATCH] add issue tag --- ...-failures-with-oc10-server-oauth2-login.md | 5 +++ ...-failures-with-ocis-server-ocis-storage.md | 6 ++++ .../deleteFilesFolders.feature | 4 +-- .../webUIFilesDetails/fileDetails.feature | 34 ++++++++++--------- 4 files changed, 31 insertions(+), 18 deletions(-) diff --git a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md index 0c0b932e2b5..9a38b04296a 100644 --- a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md +++ b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md @@ -87,6 +87,11 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUIComments/comments.feature:40](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIComments/comments.feature#L40) - [webUIComments/comments.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIComments/comments.feature#L41) - [webUIComments/comments.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIComments/comments.feature#L42) +- [webUIFilesDetails/fileDetails.feature:66](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L66) +- [webUIFilesDetails/fileDetails.feature:82](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L82) +- [webUIFilesDetails/fileDetails.feature:99](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L99) +- [webUIFilesDetails/fileDetails.feature:116](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L116) +- [webUIFilesDetails/fileDetails.feature:143](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L143) ### [Tags page not implemented yet] (https://github.com/owncloud/web/issues/5017) - [webUIDeleteFilesFolders/deleteFilesFolders.feature:144](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature#L144) diff --git a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md index 77f73687983..c8a1cbf4eb1 100644 --- a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md +++ b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md @@ -412,6 +412,12 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUIComments/comments.feature:40](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIComments/comments.feature#L40) - [webUIComments/comments.feature:41](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIComments/comments.feature#L41) - [webUIComments/comments.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIComments/comments.feature#L42) +- [webUIFilesDetails/fileDetails.feature:66](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L66) +- [webUIFilesDetails/fileDetails.feature:82](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L82) +- [webUIFilesDetails/fileDetails.feature:99](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L99) +- [webUIFilesDetails/fileDetails.feature:116](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L116) +- [webUIFilesDetails/fileDetails.feature:143](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L143) + ### [Groups endpoint does not exist](https://github.com/owncloud/ocis-reva/issues/34) diff --git a/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature b/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature index 924dd37fdea..a70de1c2e52 100644 --- a/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature +++ b/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature @@ -130,8 +130,8 @@ Feature: deleting files and folders @public_link_share-feature-required Scenario: delete files from shared by link page Given user "Alice" has created file "lorem.txt" - And the user has reloaded the current page of the webUI - And user "Alice" has shared folder "lorem.txt" with link with "read" permissions + And user "Alice" has created a public link with following settings + | path | lorem.txt | And the user has browsed to the shared-via-link page Then file "lorem.txt" should be listed on the webUI When the user deletes file "lorem.txt" using the webUI diff --git a/tests/acceptance/features/webUIFilesDetails/fileDetails.feature b/tests/acceptance/features/webUIFilesDetails/fileDetails.feature index f8a9afece91..a7e748bc09d 100644 --- a/tests/acceptance/features/webUIFilesDetails/fileDetails.feature +++ b/tests/acceptance/features/webUIFilesDetails/fileDetails.feature @@ -62,21 +62,23 @@ Feature: User can open the details panel for any file or folder When the user switches to "links" accordion item in details panel using the webUI Then the "links" details panel should be visible - @comments-app-required @public_link_share-feature-required + @issue-1158 @comments-app-required @public_link_share-feature-required Scenario: user shares a file through public link and then the details dialog should work in a Shared by link page Given user "Alice" has created folder "simple-folder" And the user has browsed to the files page - And user "Alice" has shared folder "simple-folder" with link with "read" permissions + And user "Alice" has created a public link with following settings + | path | simple-folder | + And the user has browsed to the shared-via-link page When the user opens the file action menu of folder "simple-folder" using the webUI Then the thumbnail should be visible in the app-sidebar When the user switches to "people" accordion item in details panel using the webUI Then the "people" details panel should be visible When the user switches to "links" accordion item in details panel using the webUI Then the "links" details panel should be visible - # When the user switches to "comments" accordion item in details panel using the webUI - # Then the "comments" details panel should be visible + When the user switches to "comments" accordion item in details panel using the webUI + Then the "comments" details panel should be visible - @comments-app-required @ocis-reva-issue-64 + @issue-1158 @comments-app-required @ocis-reva-issue-64 Scenario: user shares a file and then the details dialog should work in a Shared with others page Given user "Alice" has created folder "simple-folder" And the user has browsed to the files page @@ -88,12 +90,12 @@ Feature: User can open the details panel for any file or folder And the thumbnail should be visible in the app-sidebar When the user switches to "people" accordion item in details panel using the webUI Then the "people" details panel should be visible -# When the user switches to "comments" accordion item in details panel using the webUI -# Then the "comments" details panel should be visible + When the user switches to "comments" accordion item in details panel using the webUI + Then the "comments" details panel should be visible When the user switches to "links" accordion item in details panel using the webUI Then the "links" details panel should be visible - @comments-app-required @ocis-reva-issue-64 + @issue-1158 @comments-app-required @ocis-reva-issue-64 Scenario: user shares a folder via link and then the details dialog should work in a Shared with others page Given user "Alice" has created folder "simple-folder" And the user has browsed to the files page @@ -105,12 +107,12 @@ Feature: User can open the details panel for any file or folder And the thumbnail should be visible in the app-sidebar When the user switches to "people" accordion item in details panel using the webUI Then the "people" details panel should be visible -# When the user switches to "comments" accordion item in details panel using the webUI -# Then the "comments" details panel should be visible + When the user switches to "comments" accordion item in details panel using the webUI + Then the "comments" details panel should be visible When the user switches to "links" accordion item in details panel using the webUI Then the "links" details panel should be visible - @comments-app-required @ocis-reva-issue-64 + @issue-1158 @comments-app-required @ocis-reva-issue-64 Scenario: the recipient user should be able to view different areas of details panel in Shared with me page Given user "Alice" has created folder "simple-folder" And the user has browsed to the files page @@ -123,8 +125,8 @@ Feature: User can open the details panel for any file or folder And the thumbnail should be visible in the app-sidebar When the user switches to "people" accordion item in details panel using the webUI Then the "people" details panel should be visible -# When the user switches to "comments" accordion item in details panel using the webUI -# Then the "comments" details panel should be visible + When the user switches to "comments" accordion item in details panel using the webUI + Then the "comments" details panel should be visible When the user switches to "links" accordion item in details panel using the webUI Then the "links" details panel should be visible @@ -137,7 +139,7 @@ Feature: User can open the details panel for any file or folder When the user browses to the shared-with-me page using the webUI Then there should be no resources listed on the webUI - @issue-5017 @comments-app-required + @issue-1158 @issue-5017 @comments-app-required Scenario: View different areas of details panel for the folder with given tag in Tags page Given user "Alice" has created folder "simple-folder" And the user has browsed to the files page @@ -154,8 +156,8 @@ Feature: User can open the details panel for any file or folder Then the "links" details panel should be visible When the user switches to "versions" accordion item in details panel using the webUI Then the "versions" details panel should be visible - # When the user switches to "comments" accordion item in details panel using the webUI - # Then the "comments" details panel should be visible + When the user switches to "comments" accordion item in details panel using the webUI + Then the "comments" details panel should be visible Scenario: the sidebar is invisible after closing