Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oC10 / oCIS parallel / migration deployment broke because of user authentication #2604

Closed
wkloucek opened this issue Oct 11, 2021 · 6 comments
Labels
Category:Defect Existing functionality is not working as expected Type:Bug Type:Regression

Comments

@wkloucek
Copy link
Contributor

Describe the bug

Users can't login to oCIS in the parallel deployment example since #2528, because the proxy no supports only lookups by username

if claim != "username" {
return nil, "", fmt.Errorf("claim: %s not supported", claim)
}

but the example deplyoment uses the userid
PROXY_USER_OIDC_CLAIM: ocis.user.uuid # claim was added in Keycloak
PROXY_USER_CS3_CLAIM: userid # equals STORAGE_LDAP_USER_SCHEMA_UID

Steps to reproduce

Steps to reproduce the behavior:

  1. start the parallel deployment https://owncloud.dev/ocis/deployment/oc10_ocis_parallel/
  2. switch user to oCIS

Expected behavior

User logs in fine

Actual behavior

User can not login

@wkloucek wkloucek added Type:Bug Type:Regression Category:Defect Existing functionality is not working as expected labels Oct 11, 2021
@ishank011
Copy link
Contributor

@wkloucek we can get this working again by making the machine auth driver accept a claim:value input, such as username:alice. @gmgigi96 can you take this up?

@wkloucek
Copy link
Contributor Author

wkloucek commented Oct 14, 2021

The LDAP backend example is also broken because of the proxy not supporting lookups by mail.

{"level":"error","service":"proxy","error":"claim: mail not supported","time":"2021-10-14T14:15:58.601163178Z","message":"Could not get user by claim"}

@gmgigi96
Copy link
Contributor

@wkloucek we can get this working again by making the machine auth driver accept a claim:value input, such as username:alice. @gmgigi96 can you take this up?

Yes, of course

@gmgigi96
Copy link
Contributor

With cs3org/reva#2176, the machine auth accepts an optional claim

@wkloucek
Copy link
Contributor Author

The parallel deployment is confirmed to be fixed.

Will check the CS3 users deployment example after #2643 is merged again, but I think it should be fine, too.

@wkloucek
Copy link
Contributor Author

Fix confirmed 👍 The login is possible, #2646 still applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Type:Bug Type:Regression
Projects
None yet
Development

No branches or pull requests

3 participants