Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Release 3.8.1 #1100

Open
18 of 19 tasks
jesmrec opened this issue Feb 12, 2019 · 5 comments
Open
18 of 19 tasks

Release 3.8.1 #1100

jesmrec opened this issue Feb 12, 2019 · 5 comments

Comments

@jesmrec
Copy link
Contributor

jesmrec commented Feb 12, 2019

#Release a new version

TASKS:

  • [GIT] Create release branch
  • [DIS] Update changelog ios app
  • [DEV] Update version number
  • [DEV] Update readme number version app
  • [DEV] Get latest translations from master
  • [QA] Smoke Test @jesmrec
  • [QA] Upgrade Test @jesmrec
  • [QA] Check german translation in public share sheet
  • [DIS] Create itunes new version
  • [DIS] Upload new ipa to appstore
  • [DIS] Upload ipas to repos
  • [GIT] Create tag and sign it
  • [GIT] Merge branch release
  • [GIT] Update stable release
  • [DIS] Create post in central
  • [OPS] Upgrade builder machine to XCode newest version

@javiergonzper @michaelstingl

BUGS & IMPROVEMENTS:

  • (1) Cloud icon tint [FIXED]
  • (2) Top bar allignment in iPad [FIXED]
  • (3) Cancel download in iPad [FIXED]
@jesmrec
Copy link
Contributor Author

jesmrec commented Feb 12, 2019

Year updated to 2019 as well.

@jesmrec
Copy link
Contributor Author

jesmrec commented Feb 12, 2019

(1) [FIXED]

Cloud icon in the top bar is darker as usual, leading to colour confusion in case of branding:

screen shot 2019-02-12 at 18 30 31

iOS12 and XCode10. We should take a look for the incoming upgrade of XCode

@jesmrec
Copy link
Contributor Author

jesmrec commented Feb 13, 2019

(2) [FIXED]

In iPad, the allignment of the top bar is lost:

In 3.8.0:

screen shot 2019-02-13 at 09 32 20

in 3.8.1:

screen shot 2019-02-13 at 09 34 13

iOS12, iPadAir2

@jesmrec
Copy link
Contributor Author

jesmrec commented Feb 13, 2019

(3) [NR & FIXED]

  1. Download a file (not a pic), so you can check the download progress. A huge file will help to reproduce
  2. Cancel the download by tapping on (x)

Current: Nothing happens, file keeps downloading
Expected: Download cancelled

iOS12 iPadAir2

NOTE: Not a regression, but in iPad the progress does not appear (in iPhone, does)

@jesmrec
Copy link
Contributor Author

jesmrec commented Feb 14, 2019

All stuff fixed, and upgrading to 3.8.1 was correct.

Approved, ready to go to the AppStore.

CC @hosy @michaelstingl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant