Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why define SrsRtspPacketPayloadType instead of SrsRtpPacketPayloadType? #3998

Closed
suzp1984 opened this issue Mar 20, 2024 · 0 comments
Closed
Labels
EnglishNative This issue is conveyed exclusively in English.

Comments

@suzp1984
Copy link
Contributor

// The payload type, for performance to avoid dynamic cast.
enum SrsRtspPacketPayloadType
{
SrsRtspPacketPayloadTypeRaw,
SrsRtspPacketPayloadTypeFUA2,
SrsRtspPacketPayloadTypeFUA,
SrsRtspPacketPayloadTypeNALU,
SrsRtspPacketPayloadTypeSTAP,
SrsRtspPacketPayloadTypeUnknown,
};
class ISrsRtspPacketDecodeHandler
{
public:
ISrsRtspPacketDecodeHandler();
virtual ~ISrsRtspPacketDecodeHandler();
public:
// We don't know the actual payload, so we depends on external handler.
virtual void on_before_decode_payload(SrsRtpPacket* pkt, SrsBuffer* buf, ISrsRtpPayloader** ppayload, SrsRtspPacketPayloadType* ppt) = 0;
};

I was confused when read above code, I don't understand why define SrsRtspPacketPayloadType instead of SrsRtpPacketPayloadType. I checked the commit git show a1d7fe46c1 and #2304 , maybe this is a mistake.

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Mar 20, 2024
@ossrs ossrs locked and limited conversation to collaborators Mar 21, 2024
@winlinvip winlinvip converted this issue into discussion #3999 Mar 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Development

No branches or pull requests

2 participants