Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRT: How to disable covert SRT to RTMP. #3060

Closed
timokorkalainen opened this issue Jun 8, 2022 · 8 comments
Closed

SRT: How to disable covert SRT to RTMP. #3060

timokorkalainen opened this issue Jun 8, 2022 · 8 comments
Assignees
Labels
SRT It's about SRT protocol. TransByAI Translated by AI/GPT. Won't fix We won't fix it.

Comments

@timokorkalainen
Copy link

timokorkalainen commented Jun 8, 2022

Description

If an SRT gets cut without a proper end of stream message from the sender, the stream gets stuck and the same stream id can't be reused until SRS is rebooted. This may have something to do with H256 content and RTMP not supporting it.

Is there a way to prevent SRT to RTMP, as this may affect the situation? I use SRT again to pull the stream down to OBS.

1. SRS Version: all released 4.0 versions so far

Expect (Expected Behavior)

I expect the stream to be freed / ended with a preferably configurable timeout and to be reusable after that. I have not found such a timeout.

TRANS_BY_GPT3

@xiaozhihong
Copy link
Collaborator

xiaozhihong commented Jun 9, 2022

  1. Prevent SRT to RTMP, can see this PR SRT: Support Coroutine Native SRT over ST. #3010,
    using config
srt_to_rtmp off;
  1. Maybe you can use peeridletimeout to config the timeout of the stream.

@timokorkalainen
Copy link
Author

Super, thanks, I will try these out and report back.

@timokorkalainen
Copy link
Author

Ah, so none of those options are available yet in any Docker release? I tried to build the StateThread branch, but couldn't get it to work. I suppose I'll wait then for the official Docker versions. Good to know that is progressing.

@xiaozhihong
Copy link
Collaborator

xiaozhihong commented Jun 12, 2022

Ah, so none of those options are available yet in any Docker release? I tried to build the StateThread branch, but couldn't get it to work. I suppose I'll wait then for the official Docker versions. Good to know that is progressing.

Is any error in the StateThread branch, compiler error or run time error?
Yes, we will be processing this PR in these two weeks, you can keep watch on it.

@timokorkalainen
Copy link
Author

I got it to compile with no problems with SRT enabled in the config, I wasn't able to stream SRT in. Perhaps the config has changed in some way I didn't spot or something, or I missed some other parameter somewhere. Anyway, I can wait for the docker version. Thanks for the help so far!

@xiaozhihong
Copy link
Collaborator

I got it to compile with no problems with SRT enabled in the config, I wasn't able to stream SRT in. Perhaps the config has changed in some way I didn't spot or something, or I missed some other parameter somewhere. Anyway, I can wait for the docker version. Thanks for the help so far!

Have any logs about errors or warnings? Now #3010 is merged into develop branch, docker version arriving soon.

@timokorkalainen
Copy link
Author

timokorkalainen commented Jun 17, 2022

Great! I took the new 5.0.30 docker and can now run srt_to_rtmp off and the "common live" config from the wiki. I'll see if that changes the issue.

Did I understand correctly that peer_idle_timeout is not yet included in this docker version? All blocks I tried to include it in reported an illegal argument.

I suggest adding in the docs that you now need to include the srt {enabled on;} block in the vhost config. :)

@winlinvip
Copy link
Member

Seems fixed.

@winlinvip winlinvip added SRT It's about SRT protocol. Won't fix We won't fix it. labels Jun 19, 2022
@winlinvip winlinvip changed the title H256 SRT gets blocked from time to time SRT: How to disable covert SRT to RTMP. Jun 19, 2022
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SRT It's about SRT protocol. TransByAI Translated by AI/GPT. Won't fix We won't fix it.
Projects
None yet
Development

No branches or pull requests

3 participants