SRT: error in libsrt build options

[everything411]

srs/trunk/auto/depends.sh

Line 815 in 4b83865

LIBSRT_OPTIONS="--disable-app --enable-static --enable-c++11=0"

The correct option to disable apps is --enable-apps=0, while the --disable-app option is ineffective.
Previously, it was working properly because --enable-c++11=0 set ENABLE_APPS=0 internally in libsrt, disabling apps.

TRANS_BY_GPT3

[winlinvip]

👍

[zhouxiaojun2008]

--disable-app' option is equivalent to '--enable-app=0'.

srs/trunk/3rdparty/srt-1-fit/configure

Line 35 in 95bbb5a

# - you can specify --disable-option instead of --enable-option=0

app is written in C++11, so removing app also disables the compilation of libsrt with C++11. No problem at all.

TRANS_BY_GPT3

[everything411]

The --disable-app option is equivalent to --enable-app=0

srs/trunk/3rdparty/srt-1-fit/configure

Line 35 in 95bbb5a

# - you can specify --disable-option instead of --enable-option=0

The app is written in C++11, so removing the app also disables the compilation of libsrt with C++11. No problem at all.

The correct option is --enable-apps=0 or --disable-apps. The original option was misspelled, missing an 's', which made the option invalid. The original option was able to successfully disable apps due to the side effect of disabling C++11 compilation, so it should still be modified for the better.

srs/trunk/3rdparty/srt-1-fit/CMakeLists.txt

Line 864 in 95bbb5a

set(ENABLE_APPS OFF)

TRANS_BY_GPT3

[zhouxiaojun2008]

The option --disable-app is equivalent to --enable-app=0.

srs/trunk/3rdparty/srt-1-fit/configure

Line 35 in 95bbb5a

# - you can specify --disable-option instead of --enable-option=0

The app is written in C++11, so removing the app also disables the compilation of libsrt with C++11. There is no problem with that.

The correct options are --enable-apps=0 or --disable-apps. The original option was misspelled, which made it ineffective. The original option was able to successfully disable apps due to the side effect of disabling compilation with C++11. Therefore, it should still be modified for the better.

srs/trunk/3rdparty/srt-1-fit/CMakeLists.txt

Line 864 in 95bbb5a

set(ENABLE_APPS OFF)

Sorry, my mistake. Can I submit a pull request?

TRANS_BY_GPT3