Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Publish error doesn't disconnect the client #1444

Closed
samiulhsohan opened this issue Sep 15, 2019 · 4 comments · Fixed by #2687
Closed

On Publish error doesn't disconnect the client #1444

samiulhsohan opened this issue Sep 15, 2019 · 4 comments · Fixed by #2687
Assignees
@duiniuluantanqin
Labels
API HTTP-API, HTTP-Callback, etc. EnglishNative This issue is conveyed exclusively in English.
Milestone
4.0

Comments

@samiulhsohan
Copy link

Hello,
On on_publish HTTP Callback, if I don't return success, it doesn't start publishing. But the client doesn't get disconnected, it retries and retires.

I have tried sending HTTP code other than 200, and also int value other than 0, but same result.

Is there any way to disconnect the client if I don't send success response on on_publish?
@winlinvip
Copy link
Member

I will check it.

@canerd7u
Copy link

+1

@winlinvip winlinvip added the API HTTP-API, HTTP-Callback, etc. label Aug 23, 2021
@winlinvip winlinvip added this to the SRS 4.0 release milestone Aug 26, 2021
@duiniuluantanqin
Copy link
Member

TODO

@duiniuluantanqin duiniuluantanqin linked a pull request Oct 19, 2021 that will close this issue
Put the statistics code after http callback #2687
Merged
@duiniuluantanqin duiniuluantanqin mentioned this issue Oct 19, 2021
Merged
@winlinvip
Copy link
Member

Fixed in v4.0.183 592d496

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duiniuluantanqin duiniuluantanqin

Labels
API HTTP-API, HTTP-Callback, etc. EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Put the statistics code after http callback duiniuluantanqin/srs
4 participants
@winlinvip @duiniuluantanqin @canerd7u @samiulhsohan