CR #1: Comment from Fabien Lavocat #15
FabienLavocat
started this conversation in
General
Replies: 1 comment
-
Also, sending the WebRTC heartbeat is mandatory for streaming to Millicast. Simply call the following code every few seconds. ret = ice_create_request(s, whip->buf, sizeof(whip->buf), &size);
// ...
ret = ffurl_write(whip->udp_uc, whip->buf, size); |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Review for #1
I see that your readme section for Millicast is not ready yet, I was testing it and found out that the current version of the code is not working. It looks like it is missing the PRIORITY attribute in the STUN Request Binding. This attribute is mandatory (according to the RFC) and if missing, Millicast is not accepting the request.
To fix this, I've added the
STUN_ATTR_PRIORITY
attribute to theSTUNAttr
enum.Then, in the
ice_create_request
function, I add this attribute to the request, just after writing theSTUN_ATTR_USE_CANDIDATE
attribute.The value is random for now, just because I did not have time yet to do the actual compute of that value following the recommended formula.
Beta Was this translation helpful? Give feedback.
All reactions