fix(dbus): fail if cannot be primary notification server #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #87
Description
See #87 for details
Motivation and Context
Prevents the server from starting but doing nothing in the case that another service is primary for this D-Bus name
How Has This Been Tested?
Before change, running Regolith desktop on Ubuntu 23.04. By default the
rofication
demon holds the notification name in D-Bus:However
runst
does not show notifications withnotify-send
.After change, program aborts:
Additionally, killing the name holder, then running
runst
, results in showing notifications withnotify-send
. (Note: I shortened the name of the error type after running the above test)Screenshots / Logs (if applicable)
unnecessary
Types of Changes
Checklist:
Unclear how a unit test could be added here without bigger changes