From 0cbd44b6240d39acc6feac64ff22184a1e4ec1a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Fri, 6 Sep 2024 14:51:23 +0200 Subject: [PATCH 1/2] improve: cleaner throws Exception MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reconciler has this in the signature too. It is completely fine to throw exception from this method. Signed-off-by: Attila Mészáros --- .../io/javaoperatorsdk/operator/api/reconciler/Cleaner.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java index 1e75764f80..cd683fbc31 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Cleaner.java @@ -27,6 +27,6 @@ public interface Cleaner

{ * that it can be safely deleted. * @see DeleteControl#noFinalizerRemoval() */ - DeleteControl cleanup(P resource, Context

context); + DeleteControl cleanup(P resource, Context

context) throws Exception; } From b7ddc83559dbad46958a3516b43405167429be8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Fri, 6 Sep 2024 14:56:36 +0200 Subject: [PATCH 2/2] fix MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../java/io/javaoperatorsdk/operator/processing/Controller.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java index af9c3c8d9f..b1bfbe9192 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java @@ -189,7 +189,7 @@ public Map metadata() { } @Override - public DeleteControl execute() { + public DeleteControl execute() throws Exception { initContextIfNeeded(resource, context); WorkflowCleanupResult workflowCleanupResult = null;