Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: extract a <Row loading={}> component from <BalanceInfo> #502

Open
YoshiyukiSakura opened this issue Apr 29, 2022 · 0 comments
Open

Comments

@YoshiyukiSakura
Copy link
Contributor

YoshiyukiSakura commented Apr 29, 2022

currently we are handling loading icon toggling in <BalanceInfo> manually ,
it would be great if we had this <Row> and apply this way
FROM THIS

<Wrapper>
      <span>Balance</span>
      <div>
        {loadingBalance || loadingSymbol ? (
          <Loading />
        ) : (
          <ValueDisplay
            value={balance}
            decimals={decimals}
            symbol={symbol || getSymbolMetaByChain(account?.network)?.symbol}
            showAEM
          />
        )}
      </div>
    </Wrapper>

TO THIS

<Row header="Balance" content={loading ?? <ValueDisplay/> }>

<Row> can be very useful everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant