Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor opensim-gui to use the opensim-viewer codebase underneath #117

Open
aymanhab opened this issue Oct 24, 2023 · 3 comments
Open

Refactor opensim-gui to use the opensim-viewer codebase underneath #117

aymanhab opened this issue Oct 24, 2023 · 3 comments
Assignees
Labels

Comments

@aymanhab
Copy link
Member

aymanhab commented Oct 24, 2023

While we can use the javascript code as is to display the static viewer inside the opensim-gui work need to be done to explore:

  1. Using gltf in memory to communicate with the viewer
  2. 2-way communication with the viewer (as needed by the edit functionality)
  3. Handle off-line operation without backend and possibly no python connection
@aymanhab
Copy link
Member Author

There's support to run ReactApp and access it using websockets, the specifics for the openim-viewer and the opensim-gui need to be ironed out. The pros of this approach:

  1. Lighter coupling between the gui and the viewer
  2. Ease of upgrading and integrating other third party tools that are React based.

@aymanhab aymanhab changed the title Explore refactoring opensim-gui to use the opensim-viewer codebase underneath Refactor opensim-gui to use the opensim-viewer codebase underneath Jan 29, 2024
@aymanhab
Copy link
Member Author

aymanhab commented Jan 29, 2024

This issue should be converted to an epic that spans multi-sprints per the dev team plans/presentations:

  • Deploy opensim-viewer application and load into GUI without model(s)
  • Customize viewer to remove items that don't belong in application (login, gallery, toolbar,...)
  • Add options in viewer to parallel the menu in application/GUI
  • Add websocket layer around viewer code base and test two way communications
  • Convert GUI code to create and pass gltf scene instead of old threejs format
  • Remove GUI animation slider and animate in browser
  • Wire editing to viewer
  • Implement muscles.

@aymanhab
Copy link
Member Author

aymanhab commented Feb 6, 2024

issue #134

@aymanhab aymanhab added the Epic label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant