From 5ed75f0a97e2ef3c4deaa29533feafd364f54c88 Mon Sep 17 00:00:00 2001
From: Heng Qian <qianheng@amazon.com>
Date: Sun, 29 Sep 2024 13:58:16 +0800
Subject: [PATCH] Address comments

Signed-off-by: Heng Qian <qianheng@amazon.com>
---
 src/main/java/org/opensearch/agent/tools/LogPatternTool.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/opensearch/agent/tools/LogPatternTool.java b/src/main/java/org/opensearch/agent/tools/LogPatternTool.java
index 49455dd2..d65ecbcd 100644
--- a/src/main/java/org/opensearch/agent/tools/LogPatternTool.java
+++ b/src/main/java/org/opensearch/agent/tools/LogPatternTool.java
@@ -55,7 +55,7 @@
 public class LogPatternTool extends AbstractRetrieverTool {
     public static final String TYPE = "LogPatternTool";
 
-    public static String DEFAULT_DESCRIPTION = "Log Pattern Tool";
+    public static final String DEFAULT_DESCRIPTION = "Log Pattern Tool";
     public static final String TOP_N_PATTERN = "top_n_pattern";
     public static final String SAMPLE_LOG_SIZE = "sample_log_size";
     public static final String PATTERN_FIELD = "pattern_field";
@@ -119,6 +119,7 @@ public <T> void run(Map<String, String> parameters, ActionListener<T> listener)
                     : findLongestField(hits[0].getSourceAsMap());
                 if (patternField == null) {
                     listener.onResponse((T) "Pattern field is not set and this index doesn't contain any string field");
+                    return;
                 }
                 Map<String, List<Map<String, Object>>> patternGroups = new HashMap<>();
                 for (SearchHit hit : hits) {
@@ -235,7 +236,7 @@ private static int getInteger(Map<String, ?> params, String paramName) {
     }
 
     private static void checkPositive(int value, String paramName) {
-        if (value < 0) {
+        if (value <= 0) {
             throw new IllegalArgumentException(
                 LoggerMessageFormat.format("Invalid value {} for parameter {}, it should be positive", value, paramName)
             );