Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support multi datasources in the "Tenants" tab #1800

Closed
Tracked by #1794
derek-ho opened this issue Feb 22, 2024 · 3 comments
Closed
Tracked by #1794

[FEATURE] Support multi datasources in the "Tenants" tab #1800

derek-ho opened this issue Feb 22, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request triaged

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
Support multiple datasources functionality in the "Tenants" tab. This would involve some complications, since tenancy has some hooks into localstorage/sessionstorage. We would need to make sure any hooks to these stores are handled properly across datasources, such as by adding a prefix to to the key that is stored/retrieved or removing its usage where appropriate.

Acceptance criteria

  • Data source picker shared component is present on the page with a sensible UX
  • Data source selections that should be persisted across tabs is accurately persisted
  • Selected datasource prior to landing on this page is correctly populated (if applicable), and defaults are selected if not applicable
  • "Manage" sub tab is appropriately handling multiple datasources
  • Links to any dashboards/visualizaitons is correctly handling multiple datasources as well
  • "Configure" sub tab is appropriately handling multiple datasources
  • Bring in modals where appropriate to confirm/bubble up datasource information to the user

OPEN QUESTIONS

What solution would you like?
Support multiple datasources in the "Tenants" tab.

What alternatives have you considered?
None

Do you have any additional context?
Depends on #1795 to have data source picker available.

@derek-ho
Copy link
Collaborator Author

[Triage] This is part of the meta of supporting multi datasources in the security plugin.

@derek-ho
Copy link
Collaborator Author

derek-ho commented Mar 5, 2024

Adding some context that came up - since we are moving away from tenancy the cluster selector on this page may be marked as "read only" with "Local Cluster" selected with no way of selecting another cluster. Users may have to log into the other cluster to touch tenancy information, since the concept might get confusing especially with datasources themselves being specific to tenants within the local cluster.

@derek-ho
Copy link
Collaborator Author

derek-ho commented Apr 2, 2024

Merged into feature branch

@derek-ho derek-ho closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

1 participant