Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] plans to support rollup & transform APIs? #744

Closed
djmadeira opened this issue Apr 1, 2024 · 11 comments · Fixed by #797
Closed

[FEATURE] plans to support rollup & transform APIs? #744

djmadeira opened this issue Apr 1, 2024 · 11 comments · Fixed by #797
Assignees

Comments

@djmadeira
Copy link

djmadeira commented Apr 1, 2024

Is your feature request related to a problem?

JS client does not support rollup and transform features of OS

What solution would you like?

Add support to programmatically control rollup and transform features

@dblock
Copy link
Member

dblock commented Apr 1, 2024

Yes, please contribute specs to https://github.com/opensearch-project/opensearch-api-specification (mind opensearch-project/opensearch-api-specification#208 that is switching to OpenAPI), the clients are generated from there.

@djmadeira
Copy link
Author

djmadeira commented Apr 16, 2024

Trying to get these specs typed up, @dblock can you point me to the source code where rollups are implemented? The docs page isn't nearly complete enough for me to work out what all the possible values are.

@dblock
Copy link
Member

dblock commented Apr 16, 2024

I think it's in ISM

@djmadeira
Copy link
Author

Added specs for rollups and transforms

@nhtruong
Copy link
Collaborator

nhtruong commented Jun 5, 2024

The generator for this client is still its infancy but I can try and generate some of it and edit it manually

@nhtruong nhtruong self-assigned this Jun 5, 2024
@djmadeira
Copy link
Author

@nhtruong any idea when we can expect these? Is this a relatively simple change?

@nhtruong
Copy link
Collaborator

I'm aiming to have these merged and deployed by the end of the week.
I can generate these methods now. Need to iron out the edge cases and then manually insert these methods into the API.
Will keep you posted on the progress through out the week.

@nhtruong
Copy link
Collaborator

nhtruong commented Jun 11, 2024

Here's the draft. Please take a look.
Still need to add some basic typing so the IDEs can autocomplete for these added functions.
(Full typing will come later)

@nhtruong
Copy link
Collaborator

@djmadeira PR is ready for review

@nhtruong
Copy link
Collaborator

It will be part of 2.10.0 that will be released later today: #798

@nhtruong
Copy link
Collaborator

2.10.0 has been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants