Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add a max steps check for workflows #260

Closed
ohltyler opened this issue Dec 7, 2023 · 1 comment · Fixed by #266
Closed

[FEATURE] Add a max steps check for workflows #260

ohltyler opened this issue Dec 7, 2023 · 1 comment · Fixed by #266
Assignees
@dbwiddis
Labels
enhancement New feature or request

Comments

@ohltyler
Copy link
Member

ohltyler commented Dec 7, 2023

To prevent cluster overloading from this plugin or other plugins that we may call at the transport level, we should limit the size of a workflow by the number of steps. This can be added as a cluster setting, and checked during any workflow indexing operations, denying any requests that exceed the threshold.
@ohltyler ohltyler added enhancement New feature or request untriaged labels Dec 7, 2023
@minalsha minalsha removed the untriaged label Dec 7, 2023
@dbwiddis dbwiddis mentioned this issue Dec 9, 2023
Merged
@dbwiddis
Copy link
Member

Fixed in #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbwiddis dbwiddis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setting to limit max workflow steps dbwiddis/flow-framework
3 participants
@dbwiddis @ohltyler @minalsha