Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move UI Metadata from State Index to Global Context Index #140

Closed
owaiskazi19 opened this issue Nov 1, 2023 · 2 comments · Fixed by #156
Closed

[FEATURE] Move UI Metadata from State Index to Global Context Index #140

owaiskazi19 opened this issue Nov 1, 2023 · 2 comments · Fixed by #156
Assignees
Labels
enhancement New feature or request untriaged

Comments

@owaiskazi19
Copy link
Member

owaiskazi19 commented Nov 1, 2023

Is your feature request related to a problem?

We moved UI_METADATA_FIELD to state index recently here. The Search APIs as a part of #124 searches on GC index. For frontend to utilize the search APIs, the UI_METADATA_FIELD should be moved to GC index back.

What solution would you like?

  1. Move UI_METADATA_FIELD field to GC index.
  2. See if the request came from dashboard based on user-agents here and include UI_METADATA_FIELD.
  3. Else, exclude UI_METADATA_FIELD.

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@owaiskazi19 owaiskazi19 added enhancement New feature or request untriaged labels Nov 1, 2023
@joshpalis
Copy link
Member

There's already an issue for this : #135

@owaiskazi19
Copy link
Member Author

There's already an issue for this : #135

Ah! I'll close #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
2 participants