Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] gradle precommit is broken due to transportClientRatio #1954

Closed
saratvemulapalli opened this issue Jan 21, 2022 · 3 comments
Closed

[BUG] gradle precommit is broken due to transportClientRatio #1954

saratvemulapalli opened this issue Jan 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Jan 21, 2022

Describe the bug
Gradle precommit on local desktop is broken

/home/ubuntu/sarat-opensearch/server/src/test/java/org/opensearch/cluster/routing/MovePrimaryFirstTests.java:23: error: cannot find symbol
@OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.TEST, numDataNodes = 0, transportClientRatio = 0)
                                                                                                    ^
  symbol:   method transportClientRatio()
  location: @interface ClusterScope

Not sure why GHA action for precommit is going through. But its quite reproducible on local machine.
To Reproduce
Steps to reproduce the behavior:

  1. Checkout OpenSearch
  2. Run ./gradlew precommit

Host/Environment (please complete the following information):

  • OS: Mac OS BigSur, Ubuntu (Linux)
@saratvemulapalli
Copy link
Member Author

This is now fixed in main.
The changes are not backported yet to 1.x: #1445
@jainankitk can you take care of this when you back port it to 1.x.

Another follow up question, I do not know why GHA for Precommit passes consistently while on local it consistently fails.

@jainankitk
Copy link
Collaborator

@saratvemulapalli - Sure, thanks!

@jainankitk
Copy link
Collaborator

@saratvemulapalli - My bad, I missed it. Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants