Fix transient failure in UT testIndicesRoutingDiffWhenIndexDeletedAnd… #15592
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shailendra0811
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
|
❌ Gradle check result for a5aad7d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Shailendra Singh <singhlhs@amazon.com>
shailendra0811
force-pushed
the
singhlhs-rrt-fix-ut
branch
from
a5aad7d
to
4a2cb8e
Compare
| @@ -526,7 +526,7 @@ public void testIndicesRoutingDiffWhenIndexDeletedAndAdded() { | |||
| String indexNameToDelete = allIndices.get(randomIntBetween(0, allIndices.size() - 1)); | |||
| RoutingTable.Builder updatedRoutingTableBuilder = RoutingTable.builder(routingTable).remove(indexNameToDelete); | |||
|
|
|||
| String indexName = randomAlphaOfLength(randomIntBetween(1, 50)); | |||
| String indexName = randomAlphaOfLength(randomIntBetween(51, 100)); | |||
There was a problem hiding this comment.
how does this help fix the flakiness?
|
❌ Gradle check result for 4a2cb8e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix transient failure in UT testIndicesRoutingDiffWhenIndexDeletedAndAdd
Related Issues
Resolves #15588
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.