Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP update with some breaking changes #410

Closed
karthiknadig opened this issue Nov 7, 2023 · 2 comments
Closed

LSP update with some breaking changes #410

karthiknadig opened this issue Nov 7, 2023 · 2 comments

Comments

@karthiknadig
Copy link
Contributor

There is an update to LSP which removed all the anonymous types from the LSP json model. This means that all the generated types names that included *_Type* form of classes are gone.
https://github.com/microsoft/vscode-languageserver-node/pull/1308/files

Here is my plan to address this, let me know if that works for you: Make a stable release of lsprotocol (version 2023.0.0) based on the current pre-release version 2023.0.0b1. This will allow pygls to pin on 2023.0.0 stable. Then, I will publish a pre-release version 2024.0.0a1, and pygls can have a pre-release version that pins to 2024.* as it comes out.

@alcarney
Copy link
Collaborator

Makes sense to me :)

@karthiknadig
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants