Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ReturnToService line in /etc/slurm/slurm.conf? #1991

Open
mikerenfro opened this issue Jul 1, 2024 · 2 comments · May be fixed by #1994
Open

Duplicate ReturnToService line in /etc/slurm/slurm.conf? #1991

mikerenfro opened this issue Jul 1, 2024 · 2 comments · May be fixed by #1994
Labels
stale-issue

Comments

@mikerenfro
Copy link
Contributor

Currently have slurm-example-configs-ohpc-23.11.6-310.ohpc.5.1.x86_64 installed on Rocky 9.

ohpc/components/rms/slurm/SOURCES/slurm.conf.example.patch

Line 45 in 792e7cd

+ReturnToService=1

There are notes on the previous line indicating there was a ReturnToService variable removed earlier, but that doesn't appear to be the case.

[rocky@sms ~]$ grep ReturnToService /etc/slurm/slurm.conf.example
ReturnToService=1
# Adding ReturnToService Directive to starting config file (note removal of variable during above creation)
ReturnToService=1

Did I miss something, or should this line be removed from the patch, or the earlier ReturnToService line be removed via whatever method was proposed?
@adrianreber
Copy link
Member

If the upstream file already contains the line then we do not have to include it second time. Removing it from the patch sounds correct. The git history is not entirely clear why it is removed and then added back. There is some discussion in #234.

Anyway, I think the patch can be adapted to not add the line. The comment also doesn't make any sense any more.

@mikerenfro mikerenfro linked a pull request Jul 4, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

A friendly reminder that this issue had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate ReturnToService line in /etc/slurm/slurm.conf mikerenfro/ohpc
2 participants
@mikerenfro @adrianreber