This repository has been archived by the owner on May 17, 2021. It is now read-only.
remove the special toString() in order to sync with ESH #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Eichstädt-Engelen <thomas@openhab.org>
teichsta
added a commit
that referenced
this pull request
Jan 2, 2016
remove the special toString() in order to sync with ESH
|
This is imho a backward compatibility breaking change, which I'd suggest to revert. See also #3576 (comment). |
|
ok, reverted this PR. Nevertheless i scanned through the code and it seems that codewise we were not going to expect any problems. For rules you will be right for sure … |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Eichstädt-Engelen thomas@openhab.org