Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDOBSID transformer creates duplicated id field #360

Closed
subbyte opened this issue Jun 14, 2023 · 4 comments
Closed

ADDOBSID transformer creates duplicated id field #360

subbyte opened this issue Jun 14, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@subbyte
Copy link
Member

subbyte commented Jun 14, 2023

Describe the bug

The current ADDOBSID transformer implementation creates another field named id, which duplicates with the id field of any entities. Need to rename the new field as observation_id.

And we may need a unit test for ADDOBSID.

@subbyte subbyte added the bug Something isn't working label Jun 14, 2023
@leila-rashidi
Copy link
Contributor

leila-rashidi commented Jun 15, 2023

Hi @subbyte, thanks for creating this issue. I just wanted to mention that the id of the object will be changed to id:1, but it is good to change names. I hope that I can work in this issue later.

@subbyte
Copy link
Member Author

subbyte commented Jun 16, 2023

id:1 does not look a good name, and moving id to id:1 sounds confusing. It is better to have another attribute for the observation id.

Thanks for working on it! Feel free to open a PR for this when ready.

@pcoccoli
Copy link
Collaborator

pcoccoli commented Jul 6, 2023

What about x_contained_by_ref since it will contain the ID of another object, the observation that contained it?

@pcoccoli pcoccoli self-assigned this Jul 12, 2023
@pcoccoli
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants