Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pkg/errors from vendor #3039

Closed
10 tasks done
kolyshkin opened this issue Jun 24, 2021 · 5 comments
Closed
10 tasks done

remove pkg/errors from vendor #3039

kolyshkin opened this issue Jun 24, 2021 · 5 comments
Labels
kind/refactor refactoring

Comments

@AkihiroSuda
Copy link
Member

Is there an automation tool for migrating from pkg/errors to %w ?

@AkihiroSuda AkihiroSuda added the kind/refactor refactoring label Jun 24, 2021
@kolyshkin
Copy link
Contributor Author

Is there an automation tool for migrating from pkg/errors to %w ?

I am not aware of such a tool. I did it manually in the PRs referenced above (so it's basically done, the issue is mostly for tracking purposes).

@danishprakash
Copy link
Contributor

for posterity: there's also the possibility of writing a dirty program which parses the source and makes the relevant changes using an AST.

ref: https://xdg.me/rewriting-go-with-ast-transformation/

@kolyshkin
Copy link
Contributor Author

With #3152 merged, this issue is finally fixed. Hooray!

@kolyshkin kolyshkin reopened this Aug 12, 2021
@kolyshkin
Copy link
Contributor Author

Whoops, I was writing a comment to close this one, and while I was doing it, the "close with comment" button became "reopen" 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor refactoring
Projects
None yet
Development

No branches or pull requests

3 participants