Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Bundle #64

Closed
GromNaN opened this issue Mar 3, 2023 · 7 comments
Closed

Symfony Bundle #64

GromNaN opened this issue Mar 3, 2023 · 7 comments
Assignees

Comments

@GromNaN
Copy link
Contributor

GromNaN commented Mar 3, 2023

Hi, thank you for this library that is very easy to use.

I created a Symfony bundle by copying things from the Laravel integration. You can find it here: https://github.com/GromNaN/openai-symfony (work in progress).

What do you think of moving this project into the openai-php organisation? It would be good for this project to provide an integration with a 2nd major framework. The bundle is not published on Packagist yet, so that it would be a clean start.

@nunomaduro
Copy link
Contributor

Excellent idea. Just created the repository, and added you as maintainer. Can you make sure the project, structure, coding style, readme, (everything really), looks exactly like the client / laravel integration? Thanks!

@GromNaN
Copy link
Contributor Author

GromNaN commented Mar 3, 2023

Excellent. I'm going to do this right.

@nunomaduro
Copy link
Contributor

Let me know when is ready, and i will review it. ✔️

@GromNaN
Copy link
Contributor Author

GromNaN commented Mar 3, 2023

Ready. You can submit on Packagist whenever you want to.

There is a phpstan error that I'll dig with the Symfony team.

@nunomaduro
Copy link
Contributor

Done. So, now I guess we have the HTTP client issue + the tests not passing issue, that's correct?

@GromNaN
Copy link
Contributor Author

GromNaN commented Mar 4, 2023

Thank you for the publication on packagist.
Tests are green after openai-php/symfony@c7d4a74 (and the bundle is working again).

@GromNaN
Copy link
Contributor Author

GromNaN commented Mar 10, 2023

Closing as the bundle have been tagged. Thanks.

@GromNaN GromNaN closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants