Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should server.socket.address be included on http.client.request.duration metric? #341

Closed
trask opened this issue Sep 25, 2023 · 0 comments · Fixed by #350
Closed

Should server.socket.address be included on http.client.request.duration metric? #341

trask opened this issue Sep 25, 2023 · 0 comments · Fixed by #350
Assignees

Comments

@trask
Copy link
Member

trask commented Sep 25, 2023

Currently, server.socket.address is included on http.client.request.duration metric, and just want to make sure this is desired since I ran into a comment somewhere else about not including this on metrics since it can be high-ish cardinality in k8s world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants