Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark jaeger propagator as implemented for PHP #3993

Merged

Conversation

weslenteche
Copy link
Contributor

@weslenteche weslenteche commented Apr 10, 2024

Changes

Included in open-telemetry/opentelemetry-php#1187

For non-trivial changes, follow the change proposal process.

@weslenteche weslenteche requested review from a team April 10, 2024 23:32
@weslenteche
Copy link
Contributor Author

cc @brettmc

@brettmc
Copy link
Contributor

brettmc commented Apr 11, 2024

Approved, on behalf of php-maintainers

@dmathieu
Copy link
Member

The PR title will become the commit message. How about having a more descriptive one, such as Mark jaeger exporter as implemented for PHP?

@carlosalberto carlosalberto changed the title update spec php Mark jaeger exporter as implemented for PHP Apr 11, 2024
@carlosalberto carlosalberto changed the title Mark jaeger exporter as implemented for PHP Mark jaeger propagator as implemented for PHP Apr 11, 2024
@yurishkuro yurishkuro merged commit 700f513 into open-telemetry:main Apr 11, 2024
7 checks passed
@weslenteche weslenteche deleted the php-spec-jaeger-propagator branch April 11, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants