Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that exemplar reservoir default may change in a minor version #3943

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Clarify that exemplar reservoir default may change in a minor version #3943

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a79b0b6
Clarify that exemplar reservoir default may change in a minor version
jack-berg Mar 15, 2024
ff16fc0
Add changelog entry
jack-berg Mar 15, 2024
a2b260f
PR feedback
jack-berg Mar 19, 2024
1ef0543
Merge branch 'main' into clarify-examplars-best-effort
reyang Mar 19, 2024
e9392de
Merge branch 'main' into clarify-examplars-best-effort
jack-berg Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ release.

### Metrics

- Clarify that exemplar reservoir default may change in a minor version.
([#3943](https://github.com/open-telemetry/opentelemetry-specification/pull/3943))

### Logs

- Refine description of Instrumentation Scope.
Expand Down
6 changes: 6 additions & 0 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,6 +1052,12 @@ use `AlignedHistogramBucketExemplarReservoir`.
twenty (e.g. `min(20, max_buckets)`).
- All other aggregations will use `SimpleFixedSizeExemplarReservoir`.

Exemplar default reservoirs MAY change in
a [minor version bump](./../versioning-and-stability.md#minor-version-bump).
Exemplars are considered "best effort". Changing the default reservoir doesn't
jack-berg marked this conversation as resolved.
Show resolved Hide resolved
change the shape of the exported data in a way that is breaking for data
consumers.

#### SimpleFixedSizeExemplarReservoir

This reservoir MUST use an uniformly-weighted sampling algorithm based on the
Expand Down
Loading