Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify environment variable substitution is not recursive #3913

Merged
merged 12 commits into from
Mar 29, 2024
Merged

Clarify environment variable substitution is not recursive #3913

merged 12 commits into from
Mar 29, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Feb 28, 2024 •
edited
Loading

Fixes #3894

Changes

In the SDK file configuration, clarify environment variable substitution is not recursive.

For non-trivial changes, follow the change proposal process.

@marcalff marcalff requested review from a team February 28, 2024 22:36
@marcalff
Copy link
Member Author

cc @jack-berg

@marcalff marcalff mentioned this pull request Feb 28, 2024
Open
49 tasks
marcalff and others added 2 commits February 29, 2024 09:19
@marcalff @trask
Update specification/configuration/file-configuration.md
dcb2d87 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@marcalff @trask
Update specification/configuration/file-configuration.md
c5e7918 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@marcalff marcalff changed the title Clarify environment variable substitution is not reccursive Clarify environment variable substitution is not recursive Feb 29, 2024
pellared
pellared approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I created two issues while reviewing this PR:

@jack-berg
Copy link
Member

Can you add a changelog entry? Thanks!

@marcalff
Copy link
Member Author

Can you add a changelog entry? Thanks!

Done.

@jack-berg
Copy link
Member

cc @open-telemetry/configuration-maintainers

@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 22, 2024
@carlosalberto
Copy link
Contributor

Ping @open-telemetry/configuration-maintainers (otherwise we are good to go)

@marcalff
Copy link
Member Author

marcalff commented Mar 29, 2024 •
edited
Loading

Ping @open-telemetry/configuration-maintainers (otherwise we are good to go)

@jack-berg is part of configuration-maintainers, and already approved. Not sure how many approvals are needed.

@carlosalberto
Copy link
Contributor

Merging this one.

cc @MrAlias @ocelotl

@carlosalberto carlosalberto merged commit 1f48f59 into open-telemetry:main Mar 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask left review comments

@reyang reyang reyang left review comments

@carlosalberto carlosalberto carlosalberto approved these changes

@pellared pellared pellared approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[file configuration] Clarify environment variable substitution is not recursive.
7 participants
@marcalff @jack-berg @carlosalberto @trask @pellared @reyang @arminru