Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and submit an OTEP on how other semantic conventions can be adopted #583

Open
tigrannajaryan opened this issue May 5, 2020 · 5 comments
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented May 5, 2020

For example ECS defines a rich set of fields that serve a similar purpose as the OpenTelemetry semantic conventions.

Similarly, there are other sets of conventions ("other convention") that will useful to look at (e.g. Stackdriver, DataDog, Dynatrace) and see if they can be adopted fully or partially by OpenTelemetry. This will enhance OpenTelemetry's convention significantly.

Questions to answer:

  • Are there any conflicting definitions between the other conventions and existing OpenTelemetry conventions? Decide if there is a way to resolve the conflicts.
  • What portion of other conventions makes sense to be adopted by OpenTelemetry?
  • How to map the representation used in other conventions to OpenTelemertry's conventions (for example ECS uses nested objects, but OpenTelemetry uses dot notation for namespacing - how do we map these?).
@bogdandrutu
Copy link
Member

bogdandrutu commented May 5, 2020

Not sure why ECS is more important than other conventions and need to treat them specially, same argument can be made for Stackdriver, DataDog, Dynatrace, etc. Can you clarify why ECS vs the others?

Also in the comment there are a lot of topics to discuss, and will be better to split them. Thinks like "semantic convention namespace regulation" is a different topic than adopting ECS model, so probably separate issues will be better.

@tigrannajaryan tigrannajaryan changed the title Investigate and submit an OTEP on how ECS conventions can be adopted Investigate and submit an OTEP on how other semantic conventions can be adopted May 5, 2020
@tigrannajaryan
Copy link
Member Author

Moved the second part to #585

@tigrannajaryan
Copy link
Member Author

Updated this issue to make ECS one of many conventions to consider.

@tigrannajaryan
Copy link
Member Author

@roncohen would you be interested in tackling this? You already did lots of comparison work between ECS and OpenTelemetry conventions for tigrannajaryan/rfcs#4 so this would be a natural continuation.

@Oberon00
Copy link
Member

Since Dynatrace was mentioned: Due to the way our SDKs work, we do not have semantic conventions but very concrete API definitions for each operation kind that could be used to derive semantic conventions from them. You can look e.g. at the Node.js documentation: https://github.com/Dynatrace/OneAgent-SDK-for-NodeJs/#features. The C/C++ docs may not be as nice to read but may sometimes contain more details should you be interested in them: https://dynatrace.github.io/OneAgent-SDK-for-C/modules.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA
Development

No branches or pull requests

4 participants