Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logs_level_enabled feature flag #1736

Closed
wants to merge 12 commits into from

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 10, 2024

Fixes #1697

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (e2e6a6e) to head (2c8e5c1).

Current head 2c8e5c1 differs from pull request most recent head 9d80cb9

Please upload reports for the commit 9d80cb9 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1736     +/-   ##
=======================================
- Coverage   74.4%   71.3%   -3.1%     
=======================================
  Files        122     136     +14     
  Lines      19767   20836   +1069     
=======================================
+ Hits       14723   14876    +153     
- Misses      5044    5960    +916     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb marked this pull request as ready for review May 10, 2024 20:13
@lalitb lalitb requested a review from a team May 10, 2024 20:13
@lalitb lalitb closed this May 10, 2024
@lalitb lalitb reopened this May 30, 2024
@lalitb
Copy link
Member Author

lalitb commented May 30, 2024

Reopening this PR as specs is updated now - open-telemetry/opentelemetry-specification#4020

@cijothomas
Copy link
Member

Reopening this PR as specs is updated now - open-telemetry/opentelemetry-specification#4020

It is still experimental, so maybe wait till it gets stable.

@lalitb
Copy link
Member Author

lalitb commented May 30, 2024

closing again, as feature is still experimental

@lalitb lalitb closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove logs_level_enabled feature flag from Log API and SDK
2 participants