Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add db.collection.name to mysql-based instrumentation libraries #1100

Open
hannahramadan opened this issue Aug 5, 2024 · 2 comments · May be fixed by #1109
Open

Add db.collection.name to mysql-based instrumentation libraries #1100

hannahramadan opened this issue Aug 5, 2024 · 2 comments · May be fixed by #1109
Assignees
@hannahramadan
Labels
keep Ensures stale-bot keeps this issue/PR open

Comments

@hannahramadan
Copy link
Contributor

The db.collection.name attribute is conditionally required for Database spans.

Update mysql2 and trilogy instrumentations to emit this attribute.
@hannahramadan hannahramadan linked a pull request Aug 8, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Sep 5, 2024
@hannahramadan
Copy link
Contributor Author

Issue is being worked on: #1109

@kaylareopelle kaylareopelle added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hannahramadan hannahramadan

Labels
keep Ensures stale-bot keeps this issue/PR open
Projects
Ruby HTTP Metrics Semantic Conventions
Status: Placeholder
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Add Mysql2 and Trilogy db.collection.name attribute hannahramadan/opentelemetry-ruby-contrib
2 participants
@hannahramadan @kaylareopelle