Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional commit prefixed with fix! did not result in a breaking change #1053

Open
kaylareopelle opened this issue Jul 8, 2024 · 1 comment
Labels
keep Ensures stale-bot keeps this issue/PR open

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Jul 8, 2024

The conventional commits guidelines state that anything that appends a ! after a type/scope should result in a breaking change. (source)

#1038 brought to our attention that a recent change that included fix!(instrumentation): as the commit type when merged into main but this was not applied. Instead, the changes were treated like fix:.

We expected to see BREAKING CHANGE listed in the Changelog. Since the gem is still at 0.x, a major version bump shouldn't occur.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Aug 8, 2024
@kaylareopelle kaylareopelle added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Development

No branches or pull requests

1 participant