From 93c96ae1648d4b690540c099f799911342cc01c7 Mon Sep 17 00:00:00 2001 From: Sam DeHaan Date: Mon, 9 May 2022 09:50:30 -0400 Subject: [PATCH] Address PR feedback --- pipeline/directed.go | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/pipeline/directed.go b/pipeline/directed.go index b4de31f3..7ab5fce9 100644 --- a/pipeline/directed.go +++ b/pipeline/directed.go @@ -98,17 +98,18 @@ func (p *DirectedPipeline) Render() ([]byte, error) { // Operators returns a slice of operators that make up the pipeline graph func (p *DirectedPipeline) Operators() []operator.Operator { operators := make([]operator.Operator, 0) - // If possible, return the list sorted. If for some strange reason - // an Unorderable error is returned, use the list without guaranteed order if nodes, err := topo.Sort(p.Graph); err == nil { for _, node := range nodes { operators = append(operators, node.(OperatorNode).Operator()) } - } else { - nodes := p.Graph.Nodes() - for nodes.Next() { - operators = append(operators, nodes.Node().(OperatorNode).Operator()) - } + return operators + } + + // If for some unexpected reason an Unorderable error is returned, + // when using topo.Sort, return the list without ordering + nodes := p.Graph.Nodes() + for nodes.Next() { + operators = append(operators, nodes.Node().(OperatorNode).Operator()) } return operators }