Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to npm workspaces #3927

Closed
pichlermarc opened this issue Jun 20, 2023 · 6 comments · Fixed by #4238
Closed

Migrate to npm workspaces #3927

pichlermarc opened this issue Jun 20, 2023 · 6 comments · Fixed by #4238
Assignees

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Jun 20, 2023

In lerna@7.0.0 the bootstrap command was removed and is now only available via a polyfill . However, this is only a temporary solution and we should migrate to npm-workspaces as described in the page linked above.

See also

@clesleycode
Copy link

Can I take this on?

@pichlermarc
Copy link
Member Author

Can I take this on?

It's yours @clesleycode, thanks for taking this on 🙂

@clesleycode
Copy link

clesleycode commented Jul 30, 2023

👋 I'm working on this, but wanted to make sure we want to use npm over pnpm before I keep on?

@clesleycode
Copy link

@pichlermarc hey! Wanted to follow up :)

@pichlermarc
Copy link
Member Author

@pichlermarc hey! Wanted to follow up :)

Oops, sorry must've opened the notification in a new tab and then closed it. 😞

wave I'm working on this, but wanted to make sure we want to use npm over pnpm before I keep on?

Ideally we'd keep npm. Someone over at the contrib repo proposed yarn (open-telemetry/opentelemetry-js-contrib#1542) but some tooling only supports npm.

Ideally, I'd like to keep this repo and open-telemetry/opentelemetry-js-contrib's tooling in sync as it will be easier to troubleshoot and solve issues when they arise. 🙂

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 30, 2023
@dyladan dyladan linked a pull request Nov 1, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants