Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto #2586

Closed
2 tasks
dyladan opened this issue Nov 3, 2021 · 8 comments
Closed
2 tasks

Update proto #2586

dyladan opened this issue Nov 3, 2021 · 8 comments
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented Nov 3, 2021

Upgrade the version of the proto in the various OTLP exporters to support latest features

  • Move proto to a shared location if possible
  • Use autogenerated JS from the proto repo if possible
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 3, 2022
@dyladan dyladan removed the stale label Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 7, 2022
@dyladan dyladan removed the stale label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label May 9, 2022
@dyladan
Copy link
Member Author

dyladan commented May 9, 2022

not stale

@dyladan
Copy link
Member Author

dyladan commented May 9, 2022

@pichlermarc this is done now right?

@pichlermarc
Copy link
Member

Yes this is done (according to the title) 🙂

However:

  • Move proto to a shared location if possible
    • is not done: currently there are two proto locations (down from 4 locations previously)
  • Use autogenerated JS from the proto repo if possible
    • is not done AFAIK: we do not use autogenerated JS, or at least it is not documented that we do.

@pichlermarc
Copy link
Member

Also there has been another release since #2929 merged.

@dyladan
Copy link
Member Author

dyladan commented May 10, 2022

  • Move proto to a shared location if possible

    • is not done: currently there are two proto locations (down from 4 locations previously)

This should probably be a separate issue if we're going to handle it.

  • Use autogenerated JS from the proto repo if possible

    • is not done AFAIK: we do not use autogenerated JS, or at least it is not documented that we do.

This is definitely not done and was a specific choice because the autogenerated code was difficult to package the way we wanted to keep bundles small. We can create a separate issue for this if it is something we want to try again in the future, but it will be tough to do in a non-breaking way after metrics is GA I think

@dyladan dyladan closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants