Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate the whole context instead of only the current span #507

Closed
trask opened this issue Jun 13, 2020 · 4 comments
Closed

Propagate the whole context instead of only the current span #507

trask opened this issue Jun 13, 2020 · 4 comments
Assignees

Comments

@trask
Copy link
Member

trask commented Jun 13, 2020

There are lots of places where we propagate the current span to another thread.

I think we need to change all of these to propagate the whole context instead.

E.g. #503 (comment)

@trask trask added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome specification labels Jun 13, 2020
@iNikem iNikem mentioned this issue Jun 16, 2020
@iNikem
Copy link
Contributor

iNikem commented Jun 23, 2020

@trask do you have any suggestions how can I find these "lots of places"?

@trask
Copy link
Member Author

trask commented Jun 23, 2020

look for calls to Span.Builder.setParent(Span) (there aren't too many of these)

and look for calls to TracingContextUtils.currentContextWith(Span) (unfortunately there are lots of these that are not relevant to this issue, not sure how to filter these better)

@iNikem iNikem self-assigned this Jun 23, 2020
@iNikem iNikem removed the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Jun 23, 2020
@iNikem
Copy link
Contributor

iNikem commented Jun 26, 2020

@trask I propose to close this issue now. If there are more places left, they can be addressed on an ongoing basis

@trask
Copy link
Member Author

trask commented Jun 26, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants