-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single-state Aggregator and test refactor #812
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey,
MrAlias and
paivagustavo
as code owners
June 11, 2020 07:22
MrAlias
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Nothing blocking, mostly just error checking and docstring updates.
Thank you for helping improve the tests. ⭐ Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
This was referenced Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify export.Aggregator usage
The
Aggregator.Checkpoint
API is renamedSynchronizedCopy
and adds an argument, a different Aggregator into which the copy is stored. This replaces part of #799.The SDK now stores two aggregators per synchronous record, one per asynchronous record.
The
simple
Integrator stores one additional aggregator per stateful record.The constructors of all the Aggregators are modified to return a variable-length slice of aggregators. The SDK will allocate one or two of these at a time. The
AggregationSelector.AggregatorFor()
API now accepts...*export.Aggregator
to initialize one or more Aggregators with a single allocation.Test refactoring
The Aggregator tests allocate 1, 2, or 4 Aggregators. This pattern is assisted by
new2()
andnew4()
constructors in the individual Aggregator tests. External testing is assisted byUnslice2()
in thesdk/metric/aggregator/test
package.Removes a number of test
AggregatorFor
methods in favor of a single testtest.AggregationSelector()
used everywhere, where the metric name suffix indicates which class of Aggregator to use.Minor Aggregator cleanups
The
export.Aggregator
contract is thatUpdate()
andSynchronizedCopy()
are synchronized with each other. All theaggregation
interfaces (Sum
,LastValue
, ...) are not meant to be synchronized, as the caller is expected to synchronize aggregators at a higher level after the Accumulator. Some of the Aggregators used unnecessary locking and have been cleaned up.Several uses of
metric.Number
were replaced byint64
now that we usesync.Mutex
in the MinMaxSumCount and Histogram Aggregators.metric.Number(0)
expressions are replaced by0
where possible.Removed alignment tests that were unnecessary because we are using
sync.Mutex
.