Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Instrumentation Library Info in Trace Export Pipeline #805

Merged
merged 8 commits into from
Jun 10, 2020
Merged

Support Instrumentation Library Info in Trace Export Pipeline #805

merged 8 commits into from
Jun 10, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 9, 2020 •
edited
Loading

  • Add instrumentation library info to the SDK's SpanData export type.
  • Update the SDK to pass the instrumentation library from the Tracer to the exported SpanData.
  • Update the OTLP exporter and tests to support exporting instrumentation library information in the exported ResourceSpans.
  • Update the Jaeger exporter to include the instrumentation library information as span attributes.

Part of #630

@MrAlias
Update Tracer API with instrumentation version
bab7826 
Add option to the `Provider.Tracer` method to specify the
instrumentation version.

Update the global, noop, opentracing bridge, and default SDK
implementations.

This does not propagate the instrumentation library version to the
exported span. That is left for a follow-on PR.
@MrAlias
Merge remote-tracking branch 'upstream/master' into inst-ver
ee34b9c
@MrAlias
Revert trace_test.go
4eec632 
This is for the next PR.
@MrAlias
Support instrumentation library in SDK trace exports
8d5d10b
@MrAlias
Merge remote-tracking branch 'upstream/master' into inst-ver-trace-ex…
57d6866 
…port
@MrAlias
Update Jaeger exporter to export instrumentation
690669a
@MrAlias MrAlias self-assigned this Jun 9, 2020
@MrAlias MrAlias added exporters pkg:SDK Related to an SDK package area:trace Part of OpenTelemetry tracing labels Jun 9, 2020
@MrAlias MrAlias added this to the Implement v0.4.0 Specification milestone Jun 9, 2020
@jmacd
Copy link
Contributor

jmacd commented Jun 9, 2020

I guess this will break if open-telemetry/opentelemetry-proto#150 merges.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 9, 2020

I guess this will break if open-telemetry/opentelemetry-proto#150 merges.

True story, at least for the OTLP exporter. 🤷

@jmacd jmacd merged commit e53841a into open-telemetry:master Jun 10, 2020
@MrAlias MrAlias deleted the inst-ver-trace-export branch June 10, 2020 15:03
@MrAlias MrAlias mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

Assignees

@MrAlias MrAlias

Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
None yet
Milestone
Implement v0.5.0 Specification
Development

Successfully merging this pull request may close these issues.
2 participants
@MrAlias @jmacd