Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add library version option #630

Closed
MrAlias opened this issue Apr 9, 2020 · 1 comment · Fixed by #811
Closed

Add library version option #630

MrAlias opened this issue Apr 9, 2020 · 1 comment · Fixed by #811
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Milestone
Implement v0.5.0 ...

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 9, 2020

Currently the metrics API supports definition of a library name. A named meter provider should be configurable with a version option on the Meters it creats.
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 9, 2020
@MrAlias MrAlias added this to the Beta v0.5 milestone Apr 9, 2020
@jmacd
Copy link
Contributor

jmacd commented May 14, 2020

The Tracing SDK is probably in the same situation--lacking a version option in the Provider interface.

@MrAlias MrAlias added the area:trace Part of OpenTelemetry tracing label May 14, 2020
@MrAlias MrAlias self-assigned this Jun 2, 2020
This was referenced Jun 9, 2020
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
None yet
Milestone
Implement v0.5.0 Specification
Development

Successfully merging a pull request may close this issue.

Metrics instrumentation version MrAlias/opentelemetry-go
2 participants
@jmacd @MrAlias