Prepare for releasing v0.6.1 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantorrie
requested review from
Aneurysm9,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
Jun 8, 2020
Closed
Aneurysm9
approved these changes
Jun 8, 2020
lizthegrey
approved these changes
Jun 8, 2020
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Merge two event methods in span API There was an agreement to get rid of the Event interface and consolidate the two methods for adding events into one. See #57. * Eliminate the use of the Event interface There is no need for the SDK to provide the implementation of the Event interface - it is used nowhere. * Drop the Event interface It's dead code now. * Make it possible to override a finish timestamp through options Opentracing to opentelemetry bridge will certainly use this feature. * Obey the start time option * Add tests for events and custom start/end times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to differentiate the
go.opentelemetry.io/contribversion from thego.opentelemetry.io/otelversion. The tags on this repository should reflect thego.opentelemetry.io/contribversion which is referenced inside the contributed instrumentation plugins.The version of
go.opentelemetry.io/otelthat is used is usually, but not always in sync with this same version ofgo.opentelemetry.io/contrib