Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for beego instrumentation #243

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

reggiemcdonald
Copy link
Contributor

Description

This PR adds an example to the beego instrumentation. It follows exactly from the net/http example with some slight modifications

  • I removed the tracing on the client, since that is not the focus of the example
  • The beego server has the same /hello endpoint as the http-server in the net/http example, but I've added an additional endpoint at / to render an html template

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MrAlias MrAlias merged commit 2b93770 into open-telemetry:master Aug 20, 2020
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
Otherwise, this results:

```
go: finding go.opentelemetry.io latest
go: finding go.opentelemetry.io/exporter/trace/jaeger latest
go: go.opentelemetry.io/exporter/trace/jaeger@v0.0.0-20191025183852-68310ab97435 requires
	go.opentelemetry.io@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants