Use top-level common SemVersion() in creation of versioned tracer for bradfitz/gomemcache #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are intended to be used by submodules within the repo that need to specify an "instrumentation version" when creating a tracer or meter.
evantorrie
requested review from
Aneurysm9,
jmacd,
lizthegrey and
MrAlias
as code owners
MrAlias
approved these changes
Aug 15, 2020
jmacd
approved these changes
Aug 15, 2020
Aneurysm9
approved these changes
Aug 16, 2020
Aneurysm9
force-pushed
the
fitzcache-semversion
branch
from
9bd1ebb
to
8947977
Compare
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* api(trace): change trace id to byte array. * fix lint errors * add helper to create trace id from hex and improve stdout exporter. * remove comma. * fix lint * change TraceIDFromHex to be compliant with w3 trace-context * revert remove of hex16 regex because its used to parse SpanID * lint * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #225, which would need to be merged prior to this.
Also noticed this module was missing from the
dependabot.ymlchecks.