Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build check to ensure all code files include a license header #227

Closed
MrAlias opened this issue Aug 15, 2020 · 0 comments · Fixed by #228
Closed

Add build check to ensure all code files include a license header #227

MrAlias opened this issue Aug 15, 2020 · 0 comments · Fixed by #228
Assignees
@MrAlias

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Aug 15, 2020

For example:

https://github.com/open-telemetry/opentelemetry-go/blob/45b6a22cbba2fb3015c50ad095ff61f51b81aece/Makefile#L144-L152

Originally posted by @MrAlias in #224
@MrAlias MrAlias mentioned this issue Aug 15, 2020
Merged
@MrAlias MrAlias self-assigned this Aug 15, 2020
@MrAlias MrAlias mentioned this issue Aug 15, 2020
Merged
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@rghetia
WIP: Named tracer prototype (#227)
b04db14 
* named tracer prototype

* rename Manager to Provider.

* fix compile error after merge.

* rename Tracer method to GetTracer

* provider with options.

* update test.

* cleanup make circl-ci

* remove global config.

* some cleanup.

* use provider for bridge

* update propagation test.

* update examples and plugins.

* remove GlobalTracer methods.

* fix review comments.

* some more cleanup.

* remove unnecessary getTracer call in benchmark test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

License check MrAlias/opentelemetry-go-contrib
1 participant
@MrAlias